michael-s-molina commented on code in PR #32035: URL: https://github.com/apache/superset/pull/32035#discussion_r1965863060
########## superset-frontend/src/pages/DashboardList/index.tsx: ########## @@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [ 'published', 'url', 'slug', - 'changed_by', + 'changed_by.id', + 'changed_by.first_name', + 'changed_by.last_name', 'changed_on_delta_humanized', 'owners.id', 'owners.first_name', 'owners.last_name', - 'owners', Review Comment: Maybe you misunderstood what I mean. Previously, we had `owners` being declared which means that ALL attributes of `owners` were accessible like `full_name`. Now that you excluded `owners` from the fetched columns, if there's some component accessing `full_name`, it will break. I'm ok with removing the whole owners object but we need to check which attributes are in fact being used so that the projection is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
