michael-s-molina commented on code in PR #32358: URL: https://github.com/apache/superset/pull/32358#discussion_r1969587679
########## superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx: ########## @@ -224,6 +224,20 @@ const config: ControlPanelConfig = { ['y_axis_format'], ['x_axis_time_format'], ['currency_format'], + [ + { + name: 'element_border', + config: { + type: 'ColorPickerControl', + label: t('Border Color'), Review Comment: ```suggestion label: t('Border color'), ``` ########## superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx: ########## @@ -224,6 +224,20 @@ const config: ControlPanelConfig = { ['y_axis_format'], ['x_axis_time_format'], ['currency_format'], + [ + { + name: 'element_border', + config: { + type: 'ColorPickerControl', + label: t('Border Color'), + renderTrigger: true, + description: t( + 'Select border color for Heatmap elements. Initial opacity is 0. Remember to change as per need', Review Comment: ```suggestion 'Select border color for Heatmap elements. Initial opacity is 0.', ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org