geido opened a new issue, #32542: URL: https://github.com/apache/superset/issues/32542
Please refer to SIP-139 https://github.com/apache/superset/issues/29268. The `Collapse` component should be upgraded to Ant Design version 5. Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). IMPORTANT: The component needs to be upgraded in `src/components/Collapse`. The export from `superset-frontend/src/components/index.ts` as `AntdCollapse` should also be removed and all instances of `Collapse` should come from `src/components/Collapse` going forward. When upgrading the component to Ant Design 5, please ensure to include: - Remove unnecessary custom styles. We want to go as vanilla Ant Design as possible. - Proper RTL test coverage if not present yet. - A Storybook file (if not present) or all necessary changes. - Include all relevant component options in the Storybook. When opening a PR: - Name your PR refactor({Component}): Upgrade {component} to Ant Design 5 - Add screenshots of BEFORE/AFTER in your PR. - Update the [project tracker](https://github.com/apache/superset/discussions/29293) when your PR is merged. - Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
