Vitor-Avila opened a new pull request, #32599: URL: https://github.com/apache/superset/pull/32599
### SUMMARY This PR fixes an issue around file uploads to Slack (using the new APIs). The files were currently being sent with a `title` only, without a `filename`. While some of the files were loading properly "inline" (in the bot message), some larger CSVs were not displaying properly. Additionally, downloading the attachment would download a broken file (without an file type/extension). [API doc](https://api.slack.com/methods/files.getUploadURLExternal#arg_filename)) Fixes https://github.com/apache/superset/issues/32539 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before** PDF downloaded from notification: <img width="936" alt="image" src="https://github.com/user-attachments/assets/02662592-d4e5-4216-bc26-44ee67153a71"; /> **After** PDF downloaded from notification: <img width="938" alt="image" src="https://github.com/user-attachments/assets/aa9fa08e-a898-46d5-8526-755f28b46b3d"; /> ### TESTING INSTRUCTIONS 1. Set up a Slack integration. 2. Configure a report to send a dashboard as a PDF. 3. Confirm the dashboard shows properly inline. 4. Download the file, and confirm a working PDF is downloaded. 5. Configure a report for a CSV. 6. Confirm it shows properly inline, as well as works when downloaded. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/32539 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
