rusackas commented on code in PR #32596:
URL: https://github.com/apache/superset/pull/32596#discussion_r1991932469
##########
.github/workflows/pre-commit.yml:
##########
@@ -56,8 +56,7 @@ jobs:
- name: pre-commit
run: |
set +e # Don't exit immediately on failure
- # Skip auto-fixing in CI to ensure changes are committed locally
- export SKIP_FIX=1
+ export SKIP=eslint-frontend,type-checking-frontend
Review Comment:
Ahh, ok, I wasn't understanding what SKIP did, but SKIP_FIX being removed
here means we can remove it in `pre-commit-config.yml` as well, then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
