betodealmeida commented on code in PR #32701:
URL: https://github.com/apache/superset/pull/32701#discussion_r1999141815


##########
superset/models/helpers.py:
##########
@@ -722,6 +722,8 @@ class ExploreMixin:  # pylint: 
disable=too-many-public-methods
     }
     fetch_values_predicate = None
 
+    normalize_columns = False

Review Comment:
   I was testing this PR by building charts from a query, instead of a dataset, 
and I hit this error:
   
   ```
   superset_app          |   File "/app/superset/datasource/api.py", line 118, 
in get_column_values
   superset_app          |     denormalize_column = not 
datasource.normalize_columns
   superset_app          |                              
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   superset_app          | AttributeError: 'Query' object has no attribute 
'normalize_columns'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to