CharlesNkdl opened a new pull request, #32711:
URL: https://github.com/apache/superset/pull/32711

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Added some missing french translations, fixed some languages incoherence, 
fixed some formatting difference with english.
   First PR, hope i correctly followed the guidelines !!
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   `pybabel compile -d /app/superset/translations`
   
   with docker compose : 
   
   ```
   docker exec -it superset_node sh
   cd ../superset-frontend/
   npm ci
   npm run build-translation
   exit
   docker exec -it superset_app bash
   pybabel compile -d superset/translations
   exit
   ```
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Required feature flags:
   ```
   BABEL_DEFAULT_LOCALE = 'fr'
   
   LANGUAGES = {
       'en': {'flag': 'us', 'name': 'English'},
       'fr': {'flag': 'fr', 'name': 'French'},
   }
   ```
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to