Vitor-Avila opened a new pull request, #32863:
URL: https://github.com/apache/superset/pull/32863

   ### SUMMARY
   If somehow a table chart has the `time_compare` configuration set to `[]`, 
the time comparison columns (`#`, `△` and `%`) are visible in the customize 
section, even though they are not displayed in the chart.
   
   While we can't recreate this scenario through the UI (having `time_compare` 
set to `[]`) we have a handful of charts with this configuration on our 
environment, so handling this scenario in the code. It's possible to force this 
state via the API/import.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before**
   
![image](https://github.com/user-attachments/assets/203daf24-6152-4a46-9d15-9d316ec2d908)
   
   **After**
   
![image](https://github.com/user-attachments/assets/c7914dc0-0ee5-4fe1-878a-77f8e8164f5e)
   
   ### TESTING INSTRUCTIONS
   1. Create a table chart with a non temporal dimension and a metric.
   2. Set `params.time_compare` to `[]` either via the API or export/import.
   3. Access the **Customize** tab.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to