villebro commented on code in PR #32857:
URL: https://github.com/apache/superset/pull/32857#discussion_r2014729980
##########
superset/db_engine_specs/drill.py:
##########
@@ -144,3 +145,14 @@ def fetch_data(
if str(ex) == "generator raised StopIteration":
return []
raise
+
+ @staticmethod
+ def _mutate_label(label: str) -> str:
Review Comment:
@sadpandajoe no, this is fine, the mutated labels get mutated back to their
original values later in the flow. We're using the same logic in many other db
engine specs that suffer from this ambiguity problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
