mistercrunch commented on PR #32867: URL: https://github.com/apache/superset/pull/32867#issuecomment-2755671562
Did a quick pass reviewing the PR, and overall seems like a great feature! Curious, are these tiles served for free, no API key required? If it's all free and open, it seems like a better default over mapbox maybe (?) About the `bootstrap_data` comment I made, I think it's probably fair to simply leave the config empty and find a better/scalable solution in the future for the frontend to retrieve backend configuration flags async if/when needed. NOTE: I fired up an ephemeral environment so anyone can take the feature for a test drive. Though I'm realizing that mapbox doesn't seem to work out-of-the-box, curious whether we can make OSM work in eph-envs & dev-envs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
