mistercrunch commented on code in PR #32378:
URL: https://github.com/apache/superset/pull/32378#discussion_r2019235384
##########
superset-frontend/src/components/Table/index.tsx:
##########
@@ -163,42 +158,41 @@ const defaultRowSelection: Key[] = [];
const PAGINATION_HEIGHT = 40;
const HEADER_HEIGHT = 68;
-const StyledTable = styled(AntTable)<{ height?: number }>(
+const StyledTable = styled(AntTable as FC<AntTableProps>)<{ height?: number }>(
({ theme, height }) => `
color: ${theme.colorText};
.ant-table-body {
overflow: auto;
height: ${height ? `${height}px` : undefined};
}
- th.ant-table-cell {
- font-weight: ${theme.fontWeightStrong};
- color: ${theme.colorText};
- white-space: nowrap;
- overflow: hidden;
- text-overflow: ellipsis;
+ .antd5-spin-nested-loading .antd5-spin .antd5-spin-dot {
+ width: ${theme.sizeXXL}px;
+ height: unset;
}
- .ant-table-tbody > tr > td {
+ td.antd5-table-cell {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
- border-bottom: 1px solid ${theme.colorSplit};
}
- .ant-pagination-item-active {
- border-color: ${theme.colorPrimary};
+ .antd5-table-tbody > tr > td {
+ white-space: nowrap;
+ overflow: hidden;
}
- .ant-table.ant-table-small {
+ .antd5-table.antd5-table-small {
Review Comment:
wondering if that's needed or implicit (?) Seems this might exactly
re-implement internal classes (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
