michael-s-molina commented on PR #32705: URL: https://github.com/apache/superset/pull/32705#issuecomment-2765931501
Thank you so much adding folders for each component! One suggestion though is to keep the previous import from `src/components` similar to what Ant Design and `@superset-ui/core` do. This folder will probably be moved to its own NPM package later. ``` import { AsyncSelect } from 'src/components'; <-- prefer this import { AsyncSelect } from 'src/components/Select'; ``` as later we'll probably end up with ``` import { AsyncSelect } from '@superset-ui/components'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org