DamianPendrak commented on code in PR #32959:
URL: https://github.com/apache/superset/pull/32959#discussion_r2024987204
##########
superset-frontend/src/components/Collapse/index.tsx:
##########
@@ -29,74 +29,72 @@ export interface CollapseProps extends AntdCollapseProps {
animateArrows?: boolean;
}
-const Collapse = Object.assign(
- // eslint-disable-next-line @typescript-eslint/no-unused-vars
- styled(({ light, bigger, bold, animateArrows, ...props }: CollapseProps) => (
- <AntdCollapse {...props} />
- ))`
- .ant-collapse-item {
- .ant-collapse-header {
- font-weight: ${({ bold, theme }) =>
- bold ? theme.fontWeightStrong : theme.fontWeightNormal};
- font-size: ${({ bigger, theme }) =>
- bigger ? `${theme.sizeUnit * 4}px` : 'inherit'};
+const Collapse = styled((props: CollapseProps) => <AntdCollapse {...props} />)`
+ .antd5-collapse-item {
+ .antd5-collapse-header {
+ font-weight: ${({ bold, theme }) =>
+ bold ? theme.fontWeightStrong : theme.fontWeightNormal};
+ font-size: ${({ bigger, theme }) =>
+ bigger ? `${theme.sizeUnit * 4}px` : 'inherit'};
- .ant-collapse-arrow svg {
- transition: ${({ animateArrows }) =>
- animateArrows ? 'transform 0.24s' : 'none'};
- }
+ .antd5-collapse-arrow svg {
+ transition: ${({ animateArrows }) =>
+ animateArrows ? 'transform 0.24s' : 'none'};
+ }
- ${({ expandIconPosition }) =>
- expandIconPosition &&
- expandIconPosition === 'right' &&
- `
- .anticon.anticon-right.ant-collapse-arrow > svg {
+ ${({ expandIconPosition }) =>
Review Comment:
It does, but the arrow points to the right by default. In Superset, when the
arrow is on the right, it points down when closed and up when open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
