LevisNgigi opened a new pull request, #32975:
URL: https://github.com/apache/superset/pull/32975
feat(charts): add subheader option and metric customization controls
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds two key improvements to visualization controls:
1. Added subheader functionality to "Big Number with Trendline" and "Big
Number with Time Comparisons" visualizations (the latter enabled via the
CHART_PLUGINS_EXPERIMENTAL feature flag). This provides consistency with the
standard Big Number visualization which already had this option.
2. Enhanced the explore view with controls that allow users to:
- Rename comparison metrics (main, #, and delta values)
- Toggle visibility of specific metrics
- Persist these customizations when the visualization is saved
These changes improve visualization customization options and provide a more
consistent experience across related chart types.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. **Big Number with Trendline**:
- Create a new chart using the "Big Number with Trendline" visualization
- Verify the subheader option appears in the customize tab
- Add text to the subheader and confirm it displays correctly
2. **Big Number with Time Comparisons** (requires CHART_PLUGINS_EXPERIMENTAL
flag):
- Enable the CHART_PLUGINS_EXPERIMENTAL feature flag
- Create a chart using the "Big Number with Time Comparisons"
visualization
- Verify the subheader option appears and functions correctly
3. **Metric Customization**:
- Create a chart using "Table" visualizations and create a time
comparison.
- In the explore view, locate the new controls for renaming comparison
metrics
- Test renaming the main, #, and delta metrics
- Test toggling visibility of specific metrics
- Save the chart and verify the customizations persist when reopened
- Check that changes affect the visualization display correctly
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
