Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2034937065


##########
superset-frontend/src/components/index.ts:
##########
@@ -24,8 +24,11 @@
  */
 // TODO: Remove these imports
 // eslint-disable-next-line no-restricted-imports
-export { Breadcrumb as AntdBreadcrumb, Checkbox as AntdCheckbox } from 'antd';
-
+export {
+  Checkbox as AntdCheckbox,
+  Collapse as AntdCollapse,
+  Select as AntdSelect,
+} from 'antd';

Review Comment:
   ### Increasing External UI Library Dependencies <sub>![category 
Design](https://img.shields.io/badge/Design-0d9488)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Direct imports from 'antd' library are increasing despite the codebase's 
goal to reduce Ant Design dependencies and use custom components.
   
   ###### Why this matters
   This increases coupling to the Ant Design library, making it harder to 
maintain consistency, switch UI libraries, or customize components to meet 
specific needs.
   
   ###### Suggested change ∙ *Feature Preview*
   Create custom wrapper components for Collapse and Select similar to existing 
components, following the pattern used for other UI elements:
   ```typescript
   // Create new files like Collapse.tsx and maintain a consistent interface
   export { Collapse } from './Collapse';
   export { Select } from './Select';
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:054c92b0-4d0b-40df-b22c-0d0e2c887a32 -->
   
   
   [](054c92b0-4d0b-40df-b22c-0d0e2c887a32)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org