michael-s-molina commented on code in PR #33191:
URL: https://github.com/apache/superset/pull/33191#discussion_r2055905885
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -488,6 +488,7 @@ export default function transformProps(
formatter: xAxisFormatter,
rotate: xAxisLabelRotation,
},
+ splitNumber: data.length,
Review Comment:
[splitNumber](https://echarts.apache.org/en/option.html#xAxis.splitNumber)
does not guarantee that all labels will be displayed.
> Note that this number serves only as a recommendation, and the true
segments may be adjusted based on readability.
You need to set
[interval](https://echarts.apache.org/en/option.html#xAxis.interval),
[min](https://echarts.apache.org/en/option.html#xAxis.min), and
[max](https://echarts.apache.org/en/option.html#xAxis.max) to achieve this
functionality.
> As
[splitNumber](https://echarts.apache.org/en/option.html#xAxis.splitNumber) is a
recommendation value, the calculated tick may not be the same as expected. In
this case, interval should be used along with
[min](https://echarts.apache.org/en/option.html#xAxis.min) and
[max](https://echarts.apache.org/en/option.html#xAxis.max) to compulsively set
tickings.
I also agree with the checkbox (disabled by default) approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
