geido commented on code in PR #33170:
URL: https://github.com/apache/superset/pull/33170#discussion_r2058771926
##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -49,13 +52,65 @@ const StyledDivider = styled.span`
const Wrapper = styled.div`
display: flex;
justify-content: space-between;
+ width: 100%;
.antd5-input-number {
width: 100%;
+ min-width: 80px;
position: relative;
}
`;
+const SliderWrapper = styled.div`
+ margin: ${({ theme }) => theme.gridUnit * 4}px 0;
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ width: 100%;
+ min-width: 200px;
+`;
+
+const ErrorIconWrapper = styled.div`
+ margin-right: ${({ theme }) => theme.gridUnit * 2}px;
+ display: flex;
+ align-items: center;
+`;
+
+const HorizontalLayout = styled.div`
+ display: flex;
+ flex-direction: column;
+ gap: ${({ theme }) => theme.gridUnit * 4}px;
Review Comment:
Nit can we import theme at the top and then just reference it? Example
```
const SomeStyledThing = styled.div`
${({ theme }) => `
padding: ${theme.gridUnit * 2}px;
border-radius: ${theme.borderRadius}px;
border: 1px solid ${theme.colors.secondary.light3};
`}
`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
