mistercrunch commented on PR #32867: URL: https://github.com/apache/superset/pull/32867#issuecomment-2835926812
I don't think a SIP is required. I think a note in `UPDATING.md` is sufficient, it would essentially say something like: "Open Street Map is the new default for deckgl visualization as it works out-of-the-box (as opposed to mapbox that requires an API key), if you have a mapbox API key and want to allow only Mapbox, please follow the steps documented here [link]" So moving forward and in-scope for this PR: - open street map is the default and works out of the box when firing up Superset with default config. Ideally, when creating an ephemeral environment from this PR, or simply firing `docker compose up`, deckgl would now work out-of-the-box on top of OSM - Mapbox also enabled, but requires setting up an API key to work - configuration/documentation allowing for Mapbox only, mimicking the behavior prior-to-this-PR. Administrators can disable/hide OSM if they desire I think we can get consensus on this PR and move forward with all this (no need for a SIP) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
