Prokos commented on code in PR #33296:
URL: https://github.com/apache/superset/pull/33296#discussion_r2068758368
##########
superset/jinja_context.py:
##########
@@ -378,7 +378,15 @@ def get_filters(self, column: str, remove_filter: bool =
False) -> list[Filter]:
flt.get("expressionType") == "SIMPLE"
and flt.get("clause") == "WHERE"
and flt.get("subject") == column
- and val
+ and (
+ val
+ or
+ # IS_NULL and IS_NOT_NULL operators do not have a value
+ op in (
+ FilterOperator.IS_NULL.value,
+ FilterOperator.IS_NOT_NULL.value,
+ )
+ )
Review Comment:
Not me talking to an AI: after the ruff-format fix maybe the final logic is
a bit too expanded but I'll leave it to a reviewer to decide on what formatting
should be used. At least now it's passing the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
