rebenitez1802 commented on code in PR #33340:
URL: https://github.com/apache/superset/pull/33340#discussion_r2076262383
##########
superset-frontend/src/components/Datasource/Field.tsx:
##########
@@ -62,32 +64,35 @@ export default function Field<V>({
onChange: onControlChange,
});
return (
- <FormItem
- label={
- <FormLabel className="m-r-5">
- {label || fieldKey}
- {compact && description && (
- <Tooltip id="field-descr" placement="right" title={description}>
- {/* TODO: Remove fa-icon */}
- {/* eslint-disable-next-line icons/no-fa-icons-usage */}
- <i className="fa fa-info-circle m-l-5" />
- </Tooltip>
- )}
- </FormLabel>
- }
- css={inline && formItemInlineCss}
- >
- {hookedControl}
- {!compact && description && (
- <div
- css={(theme: SupersetTheme) => ({
- color: theme.colors.grayscale.base,
- [inline ? 'marginLeft' : 'marginTop']: theme.gridUnit,
- })}
+ <div css={additionalControl && css`position: relative;`}>
+ {additionalControl}
+ <FormItem
+ label={
+ <FormLabel className="m-r-5">
+ {label || fieldKey}
+ {compact && description && (
+ <Tooltip id="field-descr" placement="right"
title={description}>
+ {/* TODO: Remove fa-icon */}
+ {/* eslint-disable-next-line icons/no-fa-icons-usage */}
+ <i className="fa fa-info-circle m-l-5" />
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
