graceguo-supercat opened a new pull request #7594: [SQL Lab] fix unnecessary offline action URL: https://github.com/apache/incubator-superset/pull/7594 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY QueryAutoRefresh check running query status every 2 seconds. if query is running good, it calls `setUserOffline` (for every 2 seconds). Because Sql Lab uses redux-localStorage to sync redux state to localStorage, it seems every state update in redux will also trigger localStorage update, which is very unnecessary when there is no real state change. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: i used redux chrome extension to show redux state update:  ### TEST PLAN CI and manual check. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @michellethomas @mistercrunch @williaster
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
