msyavuz commented on PR #33170: URL: https://github.com/apache/superset/pull/33170#issuecomment-2859888480
Hey, here are some other things I noticed from manual testing: 1. When adding a filter and setting min value, if the max value is not set and Single Value filter option is not enabled, should the filter be valid? This was not the case before, i don't think this counts as a regression, but it's definitely a behavior change. 2. Placeholder for the input and slider is different when exact single value is selected  3. If filter value is required, users should not be able to clear all and apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
