mistercrunch commented on code in PR #33356: URL: https://github.com/apache/superset/pull/33356#discussion_r2078713319
########## superset-frontend/src/embedded/index.tsx: ########## @@ -41,6 +41,7 @@ setupPlugins(); const debugMode = process.env.WEBPACK_MODE === 'development'; const bootstrapData = getBootstrapData(); +const appRootPath = process.env.SUPERSET_APP_ROOT || ''; Review Comment: mmmh, wondering why we go through `process.env` here, seems we should only use `applicationRoot()` ideally always outside of module scope... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
