anantaoutlook commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2078863413
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -133,6 +242,53 @@ const config: ControlPanelConfig = {
description: t('The way the ticks are laid out on the X-axis'),
},
},
+ {
+ name: 'x_ticks_wrap_length',
Review Comment:
Fixed now
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -58,6 +101,50 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'show_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show Total'),
Review Comment:
Fixed now
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -58,6 +101,50 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'show_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show Total'),
+ default: true,
+ renderTrigger: true,
+ description: t('Show the total value in the waterfall chart'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'useFirstValueAsSubtotal',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Use first value as subtotal'),
+ default: false,
+ renderTrigger: true,
+ description: t('Render the first bar in the chart as a
subtotal'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'bold_labels',
+ config: {
+ type: 'SelectControl',
+ label: t('Bold Labels'),
Review Comment:
Fixed now
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -133,6 +220,53 @@ const config: ControlPanelConfig = {
description: t('The way the ticks are laid out on the X-axis'),
},
},
+ {
+ name: 'x_ticks_wrap_length',
+ config: {
+ type: 'TextControl',
+ label: t('X Tick Wrap Length'),
Review Comment:
Fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
