hughhhh commented on PR #32196:
URL: https://github.com/apache/superset/pull/32196#issuecomment-2864776236

   > A few comments from manual tests
   > 
   > Can we make the delete icon smaller?
   > 
   > ![Screenshot 2025-05-08 at 15 56 
34](https://private-user-images.githubusercontent.com/60598000/441739007-1975c1fe-9d7e-4852-8cf8-bb460fa74a6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY3NTEyMjAsIm5iZiI6MTc0Njc1MDkyMCwicGF0aCI6Ii82MDU5ODAwMC80NDE3MzkwMDctMTk3NWMxZmUtOWQ3ZS00ODUyLThjZjgtYmI0NjBmYTc0YTZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA5VDAwMzUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhNjUyMTM5Yzc0MjcwMzVlZDkwNDU1NzEzMDRhODU3N2E5M2M1ZDEzMjdmYzI5NDcwYjg2ZjBkODEwZDNlNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jGY-MG4LdV3rWHBPFgJeUNl5QDtrPO1Kh90xtXSsxK0)
   > 
   > I think we agreed that the range filter for now should not be there but I 
can set it and it is behaving incorrectly. ![Screenshot 2025-05-08 at 15 58 
02](https://private-user-images.githubusercontent.com/60598000/441739213-900a285c-3115-47a5-ab85-7682ecd9ec41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY3NTEyMjAsIm5iZiI6MTc0Njc1MDkyMCwicGF0aCI6Ii82MDU5ODAwMC80NDE3MzkyMTMtOTAwYTI4NWMtMzExNS00N2E1LWFiODUtNzY4MmVjZDllYzQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA5VDAwMzUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNhNGIzYWMzM2Y0Y2ZiMWYwNjVmODViZjE5NzlhN2E2YzRiYTIxZTA5MTMzZmM1NThiMTljNGM4MjMzMDliNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.h_Zhne639ozT76OpvDDF3s-9VXaITvAesNfcBWsMO7c)
   > 
   > The value filter is also behaving strange. Instead of generating an 
individual tag per option, it is separating them with comma on the same tag. 
Not sure what that behavior might cause as it is different from the standard 
value filter one.
   > 
   > ![Screenshot 2025-05-08 at 15 58 
02](https://private-user-images.githubusercontent.com/60598000/441739630-9d81c43e-4504-427d-a25a-55b70b7413bb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY3NTEyMjAsIm5iZiI6MTc0Njc1MDkyMCwicGF0aCI6Ii82MDU5ODAwMC80NDE3Mzk2MzAtOWQ4MWM0M2UtNDUwNC00MjdkLWEyNWEtNTViNzBiNzQxM2JiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA5VDAwMzUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5MGNhYjg3OGEwZTg2YzcwZmJmNTA0NDI0MDc0Nzk0ZjFiOWM3ZjQ1ZWFkMjEwNjQ0MjgyN2FiZDA0ZDljMzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jpwTiDXDVPStScrIGwngYFkAXPORkmMGqrg6w7xQUG4)
   
   I added a filter for not allowing "filter_range" so you won't see that no 
longer, for the Select this is an upstream issue that was introduced once i 
pulled from master. I'll take a look now and see if i can figure it out now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to