amaannawab923 commented on code in PR #33357:
URL: https://github.com/apache/superset/pull/33357#discussion_r2081813072
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx:
##########
@@ -381,16 +466,31 @@ export default typedMemo(function DataTable<D extends
object>({
) : null}
</div>
{searchInput ? (
- <div className="col-sm-6">
+ <StyledSpace className="col-sm-6">
+ {serverPagination && (
+ <div className="search-select-container">
+ <span className="search-by-label">Search by: </span>
+ <SearchSelectDropdown
+ searchOptions={searchOptions}
+ value={serverPaginationData?.searchColumn || ''}
+ onChange={onSearchColChange}
+ />
+ </div>
+ )}
Review Comment:
The search select dropdown component to have dynamic search column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
