geido commented on code in PR #33540:
URL: https://github.com/apache/superset/pull/33540#discussion_r2098220297


##########
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts:
##########
@@ -126,6 +126,9 @@ const buildQuery: BuildQuery<TableChartFormData> = (
       } else if (metrics?.length > 0) {
         // default to ordering by first metric in descending order
         // when no "sort by" metric is set (regardless if "SORT DESC" is set 
to true)
+        // Above is the explaination of the behaviour that why does sort 
descending control
+        // seems non responsive
+        // Hence now we will show the sort descending checkbox only sort by 
metric is provided

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to