schollz commented on code in PR #33673: URL: https://github.com/apache/superset/pull/33673#discussion_r2128741235
########## superset-embedded-sdk/README.md: ########## @@ -139,6 +139,14 @@ with the secret set in configuration variable `GUEST_TOKEN_JWT_SECRET` (see conf } ``` +In this example, the configuration file includes the following setting: + +```python +GUEST_TOKEN_JWT_AUDIENCE="superset" +``` + +If you're using a different audience value, be sure to update the GUEST_TOKEN_JWT_AUDIENCE variable accordingly. + Review Comment: I can add it, but personally I think its a little confusing. `get_url_host()` returns the value of another configuration variable - `WEBDRIVER_BASEURL` which also has its own default value. For the sake of simplicity I'd lean towards a recommendation of making clear that setting `GUEST_TOKEN_JWT_AUDIENCE` is recommended for using the SDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
