mistercrunch commented on code in PR #33603:
URL: https://github.com/apache/superset/pull/33603#discussion_r2132935469


##########
requirements/base.txt:
##########
@@ -119,6 +119,8 @@ flask-caching==2.3.1
     # via apache-superset (pyproject.toml)
 flask-compress==1.17
     # via apache-superset (pyproject.toml)
+flask-cors==4.0.2

Review Comment:
   oh, wondering if you added this manually? This is not self-evident, but this 
file is supposed to be compiled by `uv pip compile` via the script at 
https://github.com/apache/superset/blob/master/scripts/uv-pip-compile.sh .  I 
think the proper way is to alter 
https://github.com/apache/superset/blob/master/requirements/base.in#L19 to add 
a line referencing to `.[cors]`, and then running the script...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to