amaannawab923 commented on PR #33728: URL: https://github.com/apache/superset/pull/33728#issuecomment-2967604492
> Welp... that didn't QUITE work... seems the requestAnimationFrame is not working reliably. We could add a timeout, but this really seems to need an ECharts lifecyle (refreshed) hook of some sort. Hey @rusackas https://github.com/apache/superset/pull/27766/files I wrote this pr for this The problem with legend scrolling is our viz plugins do a complete re render , causing it to lose all local variables In this pr , I created a variable outside the Viz plugin , which worked out , At that time , i wasnt really good with the pr flow so wasnt able to get this pass But maybe we can use this pr as reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
