LisaHusband commented on code in PR #34016:
URL: https://github.com/apache/superset/pull/34016#discussion_r2178333083
##########
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx:
##########
@@ -38,10 +38,7 @@ import {
orderByControlSetItem,
orderDescendingControlSetItem,
} from './controls/orderBy';
-import {
- serverPageLengthControlSetItem,
- serverPaginationControlSetRow,
-} from './controls/pagination';
+import { serverPageLengthControlSetItem } from './controls/pagination';
Review Comment:
> I don't think it's necessary to keep this just for documentation. There is
always these pr's to reference if we need to implement it again. Also github
will close pr's if you reverted the changes in the pr. Nothing to pull 😄
Oh, I see! No wonder my PRs keep getting mysteriously closed 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
