amaannawab923 commented on issue #33951:
URL: https://github.com/apache/superset/issues/33951#issuecomment-3026558429
I was able to analyse the drag & drop stuff , Apparently react-sortable-hoc
isnt responsible for it ... React-dnd handles it
In OptionsWrapper.tsx ... There is this function called onShiftOptions
responsible for shuffling these Dimensions
The problem is we are executing this onHover which is doing repetitive
execution and shuffling even before drop event which is wrong
if we just execute it on onDrop ... it works properly
`
drop: (item: OptionItemInterface) => {
// Instead of repetitive calls on drag,
// we only execute the shift on drop
const { dragIndex } = item;
const hoverIndex = index;
if (dragIndex === hoverIndex) return;
onShiftOptions(dragIndex, hoverIndex);
item.dragIndex = hoverIndex;
},
`
This code corrects it ...
@msyavuz @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
