mistercrunch commented on a change in pull request #7641: [SQL Lab] Clarify SQL
Lab query and display limits
URL:
https://github.com/apache/incubator-superset/pull/7641#discussion_r290128471
##########
File path: superset/views/utils.py
##########
@@ -184,3 +184,10 @@ def get_datasource_info(datasource_id, datasource_type,
form_data):
'The datasource associated with this chart no longer exists')
datasource_id = int(datasource_id)
return datasource_id, datasource_type
+
+def apply_display_max_row_limit(data):
Review comment:
NIT: `data` is vague here, maybe `sql_results` (given it's the complex data
structure coming out of `get_sql_results`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
