Tresdon opened a new pull request #4725: Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725 This feature allows users to “publish” dashboards which essentially adds a notion of dashboards being public or private. The goal of this is to reduce the clutter that comes from a whole organization creating dashboards, many of which are not relevant to other users (or only a subset, whom they can share with selectively). The changes affect the following contexts: On creating a dashboard: - Add a boolean published column to the dashboard model and allow the owners of a given dashboard to toggle this field in the UI. On listing dashboards: - Don’t show all dashboards but instead only list dashboards with the following properties 1. Dashboards the current user owns 2. Dashboards that have been published (by any user) 3. Dashboards which the user has favorited Regarding point (3) above – The idea here was that no dashboard is strictly “private” in that it cannot be viewed if it is not published. This means that if a user creates an unpublished dashboard, they should still be able to send the link to others to share it with them. However, since the dashboard is unpublished the visitor wouldn’t see it in the list so they would need to keep the link around which isn’t a very friendly user experience. So to get around this we allow the user to favorite the dashboard and then it will show up in their list of dashboards. issues which might be relevant to this: #1799 #2792 #4002 Tasks: - [x] Add the 'published' column to the dashboard model and generate alembic migration file - [x] Don't show unpublished dashboards on listing all dashboards. - [x] Expose endpoint for toggling published status. - [x] Protect published endpoint by allowing only owners to change the status. - [x] Create React component on dashboards to represent and toggle status. - [x] Show error in the UI if somebody tries to toggle published on a dashboard which they don't own - [x] Show Users favorited dashboards in the dashboard list even if they're not published - [x] Write unit tests for dashboard visibility - [x] Show interactions with the feature in this ticket
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
