mistercrunch commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2201261210
##########
superset-frontend/src/pages/AnnotationLayerList/index.tsx:
##########
@@ -288,10 +284,10 @@ function AnnotationLayersList({
image: 'filter-results.svg',
buttonAction: () => handleAnnotationLayerEdit(null),
buttonText: (
- <>
+ <span className="ant-btn-icon">
Review Comment:
Here maybe it would be better to have `EmptyState` receive a full `Button`
object, so that the caller can craft the button properly, using the `icon` prop
on the button. Seems like the pattern of passing props to a parent component
for a children component within it isn't great, seems better to simply pass in
the component (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
