graceguo-supercat edited a comment on issue #7642: [dashboard] pass dashboard filters to share chart url in dropdown URL: https://github.com/apache/incubator-superset/pull/7642#issuecomment-498800062 > So is the `filters` prop really more of a `extraFilters` prop, to add filter on top of the chart's self-defined filters? Not exactly. For Dashboard components, `filters` prop is the current filters state in redux. `extraFilters` has merged extra dashboard filter's value with chart's own formData params. It is not stored in redux state, but will be passed to backend as query parameter. For FilterBox viz, `filters` prop is just original selected values: https://github.com/apache/incubator-superset/blob/1dc17f357cf5c94f663f7a338a7814d5f79452e9/superset/assets/src/visualizations/FilterBox/transformProps.js#L51 So I prefer to re-name Chart component's `filters` props to be `origSelectedValues`. But `origSelectedValues` is not in the standard chart props list: https://github.com/apache-superset/superset-ui/blob/7b3ab5f71398c7180b5a24f69e67016802025183/packages/superset-ui-chart/src/models/ChartProps.ts#L19 Besides `origSelectedValues` for FilterBox, is there any other viz_type using `filters` prop? @kristw
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
