mistercrunch commented on issue #7642: [dashboard] pass dashboard filters to share chart url in dropdown URL: https://github.com/apache/incubator-superset/pull/7642#issuecomment-498947624 All this is somewhat confusing (not because of your PR! was confusing before). Ideally we clarify the prop names / split them into many, or at least adding some comments to the code with the things you just mentioned.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
