Re: [PR] fix: Missing ownState and isCached props in Chart.jsx [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #34259:
URL: https://github.com/apache/superset/pull/34259#discussion_r2220098882


##########
superset-frontend/src/dashboard/components/gridComponents/Chart.jsx:
##########
@@ -163,6 +166,12 @@ const Chart = props => {
   );
   const dashboardInfo = useSelector(state => state.dashboardInfo);
 
+  const isCached = useMemo(
+    // eslint-disable-next-line camelcase
+    () => queriesResponse?.map(({ is_cached }) => is_cached) || [],
+    [queriesResponse],
+  );

Review Comment:
   ### Unnecessary Memoization of Simple Calculation <sub>![category 
Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The isCached calculation being wrapped in useMemo is unnecessary as it's a 
simple computation that doesn't justify the overhead of memoization.
   
   
   ###### Why this matters
   Using useMemo for simple calculations can actually decrease performance due 
to the overhead of maintaining the memoized value and comparing dependencies, 
when a direct calculation would be more efficient.
   
   ###### Suggested change ∙ *Feature Preview*
   Remove useMemo and calculate isCached directly:
   ```jsx
   const isCached = queriesResponse?.map(({ is_cached }) => is_cached) || [];
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5a839e2b-1f17-4bbc-a238-540c3ee13902/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5a839e2b-1f17-4bbc-a238-540c3ee13902?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5a839e2b-1f17-4bbc-a238-540c3ee13902?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5a839e2b-1f17-4bbc-a238-540c3ee13902?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5a839e2b-1f17-4bbc-a238-540c3ee13902)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:78e01f2d-6c62-4a02-9254-c332cbd9ad83 -->
   
   
   [](78e01f2d-6c62-4a02-9254-c332cbd9ad83)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org