mistercrunch commented on code in PR #34182:
URL: https://github.com/apache/superset/pull/34182#discussion_r2220862476


##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -43,6 +43,8 @@ const DEFAULT_THEME_SETTINGS = {
 
 const STORAGE_KEYS = {
   THEME_MODE: 'superset-theme-mode',

Review Comment:
   Yes, this should represent whether the user wants light/dark/os-settings for 
themselves, I made the related feature flag on by default for discoverability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to