EnxDev commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2212889804
##########
superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx:
##########
@@ -128,10 +132,13 @@ export function Button(props: ButtonProps) {
minWidth: cta ? theme.sizeUnit * 36 : undefined,
minHeight: cta ? theme.sizeUnit * 8 : undefined,
marginLeft: 0,
+ '& > .ant-btn-icon': {
+ display: 'inline-flex',
Review Comment:
We should use the same font-size for icons and text. See #52353
https://github.com/apache/superset/pull/34067#discussion_r2194801626
<img width="679" height="89" alt="Screenshot 2025-07-17 114029"
src="https://github.com/user-attachments/assets/7875091e-d887-4155-8e97-a61fab5517a3";
/>
translated: Remove the 2px font-size difference between the "pure icon
button" and the icon + text button, so that the centering and alignment issues
can be more completely fixed.
- Icon 14 px font-size 12 px
<img width="170" height="72" alt="Screenshot 2025-07-17 114322"
src="https://github.com/user-attachments/assets/c55e28e9-e424-4974-a4df-fe74d3e1665c";
/>
- Icon 14 px font-size 14 px
<img width="168" height="66" alt="Screenshot 2025-07-17 114349"
src="https://github.com/user-attachments/assets/4bf04d84-b353-4073-87ba-bc9cd61ceb4b";
/>
- Icon: 14px, font-size: 12px, text line-height: 1 instead of 1.5715
<img width="734" height="222" alt="Screenshot 2025-07-17 123137"
src="https://github.com/user-attachments/assets/dc2cfa25-0fc2-4d89-9c2c-86b63844354a";
/>
They had several issues, related PRs:
#51381
#51588
#52132
#52353
In general, it’s not recommended to apply display: inline-flex in this case,
we should change the `button line-height`
I was waiting for a response here
https://github.com/apache/superset/pull/34067#discussion_r2194801626 regarding
this topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
