etr2460 commented on a change in pull request #7641: [SQL Lab] Clarify SQL Lab
query and display limits
URL:
https://github.com/apache/incubator-superset/pull/7641#discussion_r290800400
##########
File path: superset/views/core.py
##########
@@ -2710,8 +2710,10 @@ def sql_json(self):
rendered_query,
return_results=True,
user_name=g.user.username if g.user else None)
+
+
payload = json.dumps(
- data,
+ apply_display_max_row_limit(data),
Review comment:
Hmm, so CSV download always makes an async request? If so then I'm happy to
apply `DISPLAY_MAX_ROW` to the SQL, then make a follow up issue to track the
`samples_delivered` enhancement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
