korbit-ai[bot] commented on code in PR #34276:
URL: https://github.com/apache/superset/pull/34276#discussion_r2242361348
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -467,15 +500,77 @@ function ExploreViewContainer(props) {
),
);
+ if (changedControlKeys.includes('tooltip_contents')) {
+ const tooltipContents = props.controls.tooltip_contents?.value || [];
+ const currentTemplate = props.controls.tooltip_template?.value || '';
+
+ if (tooltipContents.length > 0) {
+ const getFieldName = item => {
+ if (typeof item === 'string') return item;
+ if (item?.item_type === 'column') return item.column_name;
+ if (item?.item_type === 'metric') {
+ return item.metric_name || item.label;
+ }
+ return null;
+ };
+
+ const vizType = props.form_data?.viz_type || '';
+ const isAggregatedChart = isAggregatedChartType(vizType);
+
+ const fieldNames = tooltipContents.map(getFieldName).filter(Boolean);
+ const missingVariables = fieldNames.filter(
+ fieldName =>
+ !currentTemplate.includes(`{{ ${fieldName} }}`) &&
+ !currentTemplate.includes(`{{ limit ${fieldName}`),
+ );
+
+ if (missingVariables.length > 0) {
+ const newVariables = missingVariables.map(fieldName => {
+ const item = tooltipContents[fieldNames.indexOf(fieldName)];
+ const isColumn =
+ item?.item_type === 'column' || typeof item === 'string';
+
+ if (isAggregatedChart && isColumn) {
+ return `{{ limit ${fieldName} 10 }}`;
+ }
+ return `{{ ${fieldName} }}`;
Review Comment:
### Unexplained Magic Number in Template <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The magic number '10' is hardcoded within the template string without
explanation of its significance.
###### Why this matters
Hardcoded numbers without context make it difficult to understand their
purpose and make future modifications error-prone.
###### Suggested change ∙ *Feature Preview*
Define a named constant to explain the purpose:
```javascript
const DEFAULT_TOOLTIP_LIMIT = 10; // Maximum number of values to show in
aggregated tooltips
if (isAggregatedChart && isColumn) {
return `{{ limit ${fieldName} ${DEFAULT_TOOLTIP_LIMIT} }}`;
}
return `{{ ${fieldName} }}`;
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f1fcffb8-92c2-4357-b4d9-6c591252389b/upvote)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f1fcffb8-92c2-4357-b4d9-6c591252389b?what_not_true=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f1fcffb8-92c2-4357-b4d9-6c591252389b?what_out_of_scope=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f1fcffb8-92c2-4357-b4d9-6c591252389b?what_not_in_standard=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f1fcffb8-92c2-4357-b4d9-6c591252389b)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:d35409c7-b910-4e43-8115-ae9b39372041 -->
[](d35409c7-b910-4e43-8115-ae9b39372041)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
