korbit-ai[bot] commented on code in PR #34319:
URL: https://github.com/apache/superset/pull/34319#discussion_r2253057565
##########
superset/datasets/schemas.py:
##########
@@ -19,14 +19,29 @@
from dateutil.parser import isoparse
from flask_babel import lazy_gettext as _
-from marshmallow import fields, pre_load, Schema, validates_schema,
ValidationError
+from marshmallow import (
+ fields,
+ post_dump,
+ pre_load,
+ Schema,
+ validates_schema,
+ ValidationError,
+)
from marshmallow.validate import Length, OneOf
+from superset import security_manager
+from superset.connectors.sqla.models import SqlaTable
from superset.exceptions import SupersetMarshmallowValidationError
from superset.utils import json
get_delete_ids_schema = {"type": "array", "items": {"type": "integer"}}
get_export_ids_schema = {"type": "array", "items": {"type": "integer"}}
+get_drill_info_schema = {
+ "type": "object",
+ "properties": {
+ "dashboard_id": {"type": "integer"},
+ },
+}
Review Comment:
I see - since dashboard_id is only required for limited roles but optional
for admins/users with dataset access, keeping it as an optional parameter in
the schema makes sense. Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
