etr2460 opened a new pull request #7673: Implement data access policy modal
URL: https://github.com/apache/incubator-superset/pull/7673
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   In corporate deployments of BI tools, it's common to alert users of the 
confidential nature of data accessible within the tool and to require users to 
agree to a data use policy. This PR introduces a configurable modal and an 
audit-able log of what users have agreed to the policy and when.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   <img width="1680" alt="Screen Shot 2019-06-07 at 3 17 30 PM" 
src="https://user-images.githubusercontent.com/7409244/59136739-4f6a0480-8939-11e9-87c8-d27c8f0b2dd2.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - run db upgrade
   - test different values for all config params
   - see modal on welcome page, dashboard, explore, profile, sqllab
   - test db downgrade
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [x] Requires DB Migration.
   - [x] Confirm DB Migration upgrade and downgrade tested.
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @john-bodley, @michellethomas, @graceguo-supercat

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to