Antonio-RiveroMartnez commented on code in PR #34602:
URL: https://github.com/apache/superset/pull/34602#discussion_r2260994410
##########
superset-frontend/packages/superset-ui-core/src/components/Label/reusable/DatasetTypeLabel.tsx:
##########
@@ -45,7 +45,16 @@ export const DatasetTypeLabel:
React.FC<DatasetTypeLabelProps> = ({
const labelType = datasetType === 'physical' ? 'primary' : 'default';
return (
- <Label icon={icon} type={labelType}>
+ <Label
+ icon={icon}
+ type={labelType}
+ style={{
+ color:
+ labelType === 'primary'
+ ? theme.colors.primary.dark2
+ : theme.colorPrimary,
Review Comment:
Is it possible to rename these? because the condition is `=== 'primary'` and
then both colors are being called with a `primary` key, actually it's
counterintuitive that if `=== 'primary'` we use dark2 and when not primary we
use `colorPrimary`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
