yousoph commented on code in PR #34406:
URL: https://github.com/apache/superset/pull/34406#discussion_r2264088998
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:
##########
@@ -358,7 +358,22 @@ const config: ControlPanelConfig = {
['x_axis_time_format'],
[xAxisLabelRotation],
[xAxisLabelInterval],
- ...richTooltipSection,
+ [<ControlSubSectionHeader>{t('Tooltip')}</ControlSubSectionHeader>],
+ [
+ {
+ name: 'show_query_identifiers',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show query identifiers'),
+ description: t(
+ 'Add Query A and Query B identifiers to tooltips to help
differentiate series',
+ ),
+ default: false,
+ renderTrigger: true,
+ },
+ },
+ ],
+ ...richTooltipSection.slice(1), // Skip the tooltip header since we
added our own
Review Comment:
It does function as expected but maybe this code needs to be fixed
My guess is it did something weird with the section header since the new
control I added was at the top of the "Tooltip" section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
