amaannawab923 commented on code in PR #33791:
URL: https://github.com/apache/superset/pull/33791#discussion_r2276145208
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -251,6 +253,13 @@ function SelectPageSize({
const getNoResultsMessage = (filter: string) =>
filter ? t('No matching records found') : t('No records found');
+const sanitizeHtmlValue = (value: DataRecordValue): DataRecordValue => {
Review Comment:
Yes this is different , its about extracting value from Html Tag ->
Input :
"<a href="https://www.google.com/search?q=United Kingdom">United Kingdom</a>"
Expected Output:
United Kingdom
Sanitise Html function would just sanitise that html to remove malicious
code
For now , i guess this is component specific , because it will only come to
use here in Table
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -251,6 +253,13 @@ function SelectPageSize({
const getNoResultsMessage = (filter: string) =>
filter ? t('No matching records found') : t('No records found');
+const sanitizeHtmlValue = (value: DataRecordValue): DataRecordValue => {
Review Comment:
Yes this is different , its about extracting value from Html Tag ->
Input :
< /a href="https://www.google.com/search?q=United Kingdom">United
Kingdom</a>"
Expected Output:
United Kingdom
Sanitise Html function would just sanitise that html to remove malicious
code
For now , i guess this is component specific , because it will only come to
use here in Table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
