mistercrunch commented on code in PR #34640:
URL: https://github.com/apache/superset/pull/34640#discussion_r2277376695
##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -74,7 +74,62 @@ const StyledLabel = styled(Typography.Text)`
`}
`;
+const StyledBackground = styled.div`
+ ${({ theme }) => {
+ const bgImageUrl = theme.loginPageBackgroundImageUrl;
+ const overlayColor =
+ theme.loginPageBackgroundOverlayColor || 'rgba(0, 0, 0, 0.5)';
Review Comment:
yes ... one thing I've been meaning to add to the theming framework is
`component` support for `useTheme()`. Meaning wherever we do `const theme =
useTheme()`, we could instead/optionally call `useTheme('Login')`, and it would
return a full theme object with the component overrides applied.
Would be fairly easy to add, but we also need to tackle `css` and `styled`
and got tangled up last time I tried to do this as they're kind of like js
"decorators" (forgot the official name) but was a mind-bend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
