justinpark opened a new pull request, #34720: URL: https://github.com/apache/superset/pull/34720
### SUMMARY When using the improved SQLLab persistence mode, an ID value is initially generated to manage the tab in localStorage when the tab is created. After syncing with the server, this ID is immediately replaced with the server’s tabViewId, and subsequent data synchronization uses this new ID. Since this ID serves as the key for the SQLLab tab, updating the value causes React to treat it as a new tab, resulting in the component being re-rendered. To solve this issue, we now preserve the ID for the duration of the session and additionally store the tabViewId. We have modified the system to use tabViewId specifically for data synchronization, which resolves the problem of tab flushing. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/user-attachments/assets/61ac3220-aa7d-461e-bfec-c3063860a47e After: https://github.com/user-attachments/assets/9266eb7f-aea9-47f2-870b-778970767565 ### TESTING INSTRUCTIONS Create a new tab, and then observe that the tab is flushed a few seconds later. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
