kgabryje commented on code in PR #34705:
URL: https://github.com/apache/superset/pull/34705#discussion_r2282915911
##########
superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx:
##########
@@ -82,6 +82,7 @@ export const FilterItem = styled.button`
background: none;
outline: none;
width: 100%;
+ color: ${theme.colors.grayscale.light5};
Review Comment:
So in this case, the text is displayed on the tooltip's dark background (in
light mode) or light background (in dark mode). With `theme.colorText` we'd
display dark text on dark background or light text on light background, while
with `theme.colors.grayscale.light5` the colors are invented.
Is there an antd text color token which has its colors inverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
